Re: [PATCH 2/2] video: fbdev: Enable Xilinx FB for ZynqMP

[Daniel Vetter]

On Mon, Aug 14, 2017 at 3:46 PM, Michal Simek <michal.simek@xxxxxxxxxx> wrote:
> On 14.8.2017 15:42, Linus Walleij wrote:
>> On Tue, Aug 8, 2017 at 10:10 AM, Michal Simek <michal.simek@xxxxxxxxxx> wrote:
>>
>>> Enable this driver for Xilinx ZynqMP.
>>>
>>> Signed-off-by: Michal Simek <michal.simek@xxxxxxxxxx>
>>
>> Not a comment on the patch per se, but I would advice you to look into
>> migrating the Xilinx frame buffer to DRI/DRM/KMS.
>>
>> The recent CMA helpers has made it very simple and focused to write
>> DRM drivers. See for example drivers/gpu/drm/pl111
>
> There is a lot of work done by xilinx in this area gpu/drm/kms. I am
> trying to upstream what xilinx has in soc tree and this change is there.
> Maybe in this case it is useless and none is using it but it is there
> and I don't want to break user. There shouldn't be any technical problem
> to run this old fb driver in pl on arm64.

A proper drm kms driver gives you backwards compat for fbdev for free.
And we're taking in patches to fill feature gaps in our fbdev
emulation as people hit them. There no reason nowadays at all to merge
new fbdev native drivers, your users will be taken care of by a drm
kms driver fully.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch