Re: [PATCH v2] platform/x86: ideapad-laptop: Expose conservation mode switch

[Hao Wei Tee]

On 14/8/2017 23:32, Andy Shevchenko wrote:
> On Mon, Aug 14, 2017 at 5:17 PM, Hao Wei Tee <angelsl@xxxxxxx> wrote:
>> This exposes the battery conservation mode present on some (?) IdeaPads.
>> The mode is set by calling ACPI method SBMC with argument 3 (on) or
>> 5 (off). Status is reported in bit 5 of the return value of ACPI method
>> GBMD.
> 
> Thanks for an update, this looks pretty much good!
> 
> Still some kind of nitpicks below.
> 
>> +#define GBMD_CONSERVATION_BIT (5)
> 
>> +enum {
>> +       SBMC_CONSERVATION_ON = 3,
>> +       SBMC_CONSERVATION_OFF = 5,
> 
> Looks to me like
> GBMD = Get BM Data
> SBMC = Send BM Command
> 
> Thus, I would leave BM only in the above (do you know by the way what
> BM stands for?

Now that you mention it, it might stand for battery management.

-- 
Hao Wei