Re: nvmet_fc: add defer_req callback for deferment of cmd buffer return

From: James Smart
Date: Mon Aug 14 2017 - 13:57:41 EST


On 8/14/2017 9:38 AM, Christoph Hellwig wrote:
On Mon, Aug 14, 2017 at 10:19:24AM -0400, Dave Jones wrote:
> +
> + /* Cleanup defer'ed IOs in queue */
> + list_for_each_entry(deferfcp, &queue->avail_defer_list, req_list) {
> + list_del(&deferfcp->req_list);
> + kfree(deferfcp);
> + }

Shouldn't this be list_for_each_entry_safe ?

It should. James, can you send a fixup?


yes - I was had already identified this fix and in the process of putting it out.

-- james