Re: [PATCH v2 2/2] i2c: mediatek: Add i2c compatible for MediaTek MT7622

[Wolfram Sang]

On Mon, Aug 14, 2017 at 09:36:56AM +0800, Jun Gao wrote:
> On Sat, 2017-08-12 at 16:44 +0200, Wolfram Sang wrote:
> > > +static const struct i2c_adapter_quirks mt7622_i2c_quirks = {
> > > +	.max_num_msgs = 255,
> > > +	.max_write_len = 65535,
> > > +	.max_read_len = 65535,
> > > +	.max_comb_1st_msg_len = 65535,
> > > +	.max_comb_2nd_msg_len = 65535,
> > > +};
> > 
> > That looks like no quirks? Then just leave the quirks pointer below
> > empty.
> > 
> Compare to MT8173 i2c controller, MT7622 limits message numbers to 255.

I see. But you can safely drop all the length settings. The i2c core has
this comment in quirk handling:

/* Check if val is exceeding the quirk IFF quirk is non 0 */

IFF means "if and only if".

Attachment: signature.asc
Description: PGP signature