Re: [PATCH] selftests: timers: freq-step: fix compile error

From: John Stultz
Date: Mon Aug 14 2017 - 16:34:19 EST


On Mon, Aug 14, 2017 at 1:17 PM, Shuah Khan <shuahkh@xxxxxxxxxxxxxxx> wrote:
> On 08/14/2017 02:12 PM, John Stultz wrote:
>> On Wed, Aug 9, 2017 at 3:05 PM, Shuah Khan <shuahkh@xxxxxxxxxxxxxxx> wrote:
>>> Fix compile error due to ksft_exit_skip() update to take var_args.
>>>
>>> freq-step.c: In function âinit_testâ:
>>> freq-step.c:234:3: error: too few arguments to function âksft_exit_skipâ
>>> ksft_exit_skip();
>>> ^~~~~~~~~~~~~~
>>> In file included from freq-step.c:26:0:
>>> ../kselftest.h:167:19: note: declared here
>>> static inline int ksft_exit_skip(const char *msg, ...)
>>> ^~~~~~~~~~~~~~
>>> <builtin>: recipe for target 'freq-step' failed
>>>
>>> Signed-off-by: Shuah Khan <shuahkh@xxxxxxxxxxxxxxx>
>>
>>
>> Acked-by: John Stultz <john.stultz@xxxxxxxxxx>
>>
>> This is a build regression in 4.13-rc so should go-to Linus promptly.
>>
>> (Shuah: Let me know if you want me to send this in via Thomas, or you
>> want to send it in directly)
>>
>> thanks
>> -john
>>
>
> John,
>
> I am planning to send it to Linus with a few other fixes in linux-kselftest
> fixes branch for 4.13-rc6

Great! Thanks again for sending this out and sorry for not replying sooner!

-john