Re: [PATCH net-next 01/11] net: dsa: legacy: assign dst->applied

From: Andrew Lunn
Date: Mon Aug 14 2017 - 18:58:28 EST

Next message: Long Li: "RE: [[PATCH v1] 19/37] [CIFS] SMBD: Manage credits on SMBD client and server"
Previous message: Long Li: "RE: [[PATCH v1] 14/37] [CIFS] SMBD: Post a SMBD data transfer message with page payload"
In reply to: Vivien Didelot: "[PATCH net-next 01/11] net: dsa: legacy: assign dst->applied"
Next in thread: Vivien Didelot: "[PATCH net-next 09/11] net: dsa: debugfs: add port mdb"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

On Mon, Aug 14, 2017 at 06:22:32PM -0400, Vivien Didelot wrote:
> The "applied" boolean of the dsa_switch_tree is only set in the new
> bindings. This patch sets it in the legacy code as well.

What is missing here is: Why?

I see the next patch does a WARN_ON(!applied). Why have a WARN_ON?

Andrew

Next message: Long Li: "RE: [[PATCH v1] 19/37] [CIFS] SMBD: Manage credits on SMBD client and server"
Previous message: Long Li: "RE: [[PATCH v1] 14/37] [CIFS] SMBD: Post a SMBD data transfer message with page payload"
In reply to: Vivien Didelot: "[PATCH net-next 01/11] net: dsa: legacy: assign dst->applied"
Next in thread: Vivien Didelot: "[PATCH net-next 09/11] net: dsa: debugfs: add port mdb"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]