Re: [PATCH v2 0/1] add (un)patch callbacks

[Miroslav Benes]

On Tue, 8 Aug 2017, Joe Lawrence wrote:

> Hi folks,
> 
> This is v2 of the livepatch (un)patch hook/notifier/callback/etc code.
> 
> The documentation is still a little rough, but I wanted to post up the
> code for feedback before getting too far in revising it.
> 
> This implements the pre and post handlers as Josh suggested.  See
> summary of related changes below...
> 
> v2:
> - s/hooks/callbacks/g
> - implemented pre-(un)patch and post-(un)patch callbacks
>   - pre-patch and pre-unpatch callbacks run from callers of
>     klp_patch_object() and klp_unpatch_object()
>   - post-patch and post-unpatch callbacks run from
>     klp_complete_transition() and klp_module_coming/going()
> - reduce callbacks from a list to a single per-klp_object instance
> - revamp the sample callback demo
> - revamp documentation
> 
> Feedback appreciated as always.

Looks almost good to me. v3 with Josh's review should be ok.

Miroslav