Re: [PATCH] irq_work: improve the flag definitions

[Bartosz Golaszewski]

2017-08-14 13:56 GMT+02:00 Bartosz Golaszewski <brgl@xxxxxxxx>:
> IRQ_WORK_FLAGS is defined simply to 3UL. This is confusing as it
> says nothing about its purpose. Define IRQ_WORK_FLAGS as a bitwise
> OR of IRQ_WORK_PENDING and IRQ_WORK_BUSY.
>
> While we're at it: use the BIT() macro for all flags.
>
> Signed-off-by: Bartosz Golaszewski <brgl@xxxxxxxx>
> ---
>  include/linux/irq_work.h | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/include/linux/irq_work.h b/include/linux/irq_work.h
> index 47b9ebd4a74f..467a58e7e0da 100644
> --- a/include/linux/irq_work.h
> +++ b/include/linux/irq_work.h
> @@ -12,10 +12,10 @@
>   * busy      NULL, 2 -> {free, claimed} : callback in progress, can be claimed
>   */
>
> -#define IRQ_WORK_PENDING       1UL
> -#define IRQ_WORK_BUSY          2UL
> -#define IRQ_WORK_FLAGS         3UL
> -#define IRQ_WORK_LAZY          4UL /* Doesn't want IPI, wait for tick */
> +#define IRQ_WORK_PENDING       BIT(0)
> +#define IRQ_WORK_BUSY          BIT(1)
> +#define IRQ_WORK_FLAGS         (IRQ_WORK_PENDING | IRQ_WORK_BUSY)
> +#define IRQ_WORK_LAZY          BIT(3) /* Doesn't want IPI, wait for tick */

Superseded by v2 - 4UL is BIT(2), not BIT(3).

Best regards,
Bartosz Golaszewski