Re: [PATCH] printk: Clean up do_syslog() error handling

[Petr Mladek]

On Sat 2017-07-29 20:36:36, Nikitas Angelinas wrote:
> The error variable in do_syslog() is preemptively set to the error code
> before the error condition is checked, and then set to 0 if the error
> condition is not encountered. This is not necessary, as it is likely
> simpler to return immediately upon encountering the error condition. A
> redundant set of the error variable to 0 is also removed.
> 
> This patch has been build-tested on x86_64, but not tested for
> functionality.
> 
> Signed-off-by: Nikitas Angelinas <nikitas.angelinas@xxxxxxxxx>

The code looks better. Also the patch looks correct.

Acked-by: Petr Mladek <pmladek@xxxxxxxx>

I have pushed it into for-4.14 branch.

Best Regards,
Petr