Re: [PATCH v2] sctp: fully initialize the IPv6 address in sctp_v6_to_addr()

From: Marcelo Ricardo Leitner
Date: Tue Aug 15 2017 - 12:32:06 EST


On Tue, Aug 15, 2017 at 08:37:49AM -0700, Eric Dumazet wrote:
> On Tue, 2017-08-15 at 12:05 -0300, Marcelo Ricardo Leitner wrote:
>
> > Ok, but I should see a difference in the generated code, right?
>
> Depends on the compiler. Have you tried older versions ?
>

This was with gcc 6.4.1, fc25 standard. Only tested with it and didn't
check clang either.

> One argument is that following struct member definition eases code
> review.
>
> (It is easier to catch a field init is missing)

And a good one, yes.

Thanks,
Marcelo