Re: [PATCH v2 3/4] staging: pi433: Renaming Enums

[Dan Carpenter]

On Wed, Aug 16, 2017 at 10:53:20AM +0530, Rishabh Hardas wrote:
> Remove camel casing by renaming enums.
> 
> Signed-off-by: Rishabh Hardas <rishabhhardas@xxxxxxxxx>
> ---
>  drivers/staging/pi433/pi433_if.h  | 36 ++++++++++++++++--------------------
>  drivers/staging/pi433/rf69.c      | 26 +++++++++++++-------------
>  drivers/staging/pi433/rf69.h      | 26 +++++++++++++-------------
>  drivers/staging/pi433/rf69_enum.h | 16 ++++++++--------
>  4 files changed, 50 insertions(+), 54 deletions(-)
> 
> diff --git a/drivers/staging/pi433/pi433_if.h b/drivers/staging/pi433/pi433_if.h
> index 84032f3..2929de0 100644
> --- a/drivers/staging/pi433/pi433_if.h
> +++ b/drivers/staging/pi433/pi433_if.h
> @@ -62,21 +62,20 @@ struct pi433_tx_cfg {
>  	__u16			bit_rate;
>  	__u32			dev_frequency;
>  	enum modulation		modulation;
> -	enum modShaping		modShaping;
> +	enum mod_shaping		modShaping;

Now the names don't line up.

regards,
dan carpenter