Re: [PATCH v2] watchdog: dw_wdt: fix overflow issue in dw_wdt_top_in_seconds

From: kbuild test robot
Date: Wed Aug 16 2017 - 16:31:32 EST


Hi Huibin,

[auto build test ERROR on linus/master]
[also build test ERROR on v4.13-rc5 next-20170816]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url: https://github.com/0day-ci/linux/commits/Huibin-Hong/watchdog-dw_wdt-fix-overflow-issue-in-dw_wdt_top_in_seconds/20170817-033555
config: sparc64-allmodconfig (attached as .config)
compiler: sparc64-linux-gnu-gcc (Debian 6.1.1-9) 6.1.1 20160705
reproduce:
wget https://raw.githubusercontent.com/01org/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
make.cross ARCH=sparc64

All errors (new ones prefixed by >>):

drivers/watchdog/dw_wdt.c: In function 'dw_wdt_top_in_seconds':
>> drivers/watchdog/dw_wdt.c:77:38: error: 'dw_wdt' is a pointer; did you mean to use '->'?
return (cycles / clk_get_rate(dw_wdt.clk));
^
->
drivers/watchdog/dw_wdt.c:78:1: warning: control reaches end of non-void function [-Wreturn-type]
}
^

vim +77 drivers/watchdog/dw_wdt.c

68
69 static inline int dw_wdt_top_in_seconds(struct dw_wdt *dw_wdt, unsigned top)
70 {
71 /*
72 * There are 16 possible timeout values in 0..15 where the number of
73 * cycles is 2 ^ (16 + i) and the watchdog counts down.
74 */
75 unsigned int cycles = 1 << (16 + top);
76
> 77 return (cycles / clk_get_rate(dw_wdt.clk));
78 }
79

---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation

Attachment: .config.gz
Description: application/gzip