Re: [kernel-hardening] [PATCHv2 2/2] extract early boot entropy from the passed cmdline

[Kees Cook]

On Wed, Aug 16, 2017 at 9:56 PM, Nick Kralevich <nnk@xxxxxxxxxx> wrote:
> On Wed, Aug 16, 2017 at 3:46 PM, Laura Abbott <labbott@xxxxxxxxxx> wrote:
>> From: Daniel Micay <danielmicay@xxxxxxxxx>
>>
>> Existing Android bootloaders usually pass data useful as early entropy
>> on the kernel command-line. It may also be the case on other embedded
>> systems. Sample command-line from a Google Pixel running CopperheadOS:
>>
>
> Why is it better to put this into the kernel, rather than just rely on
> the existing userspace functionality which does exactly the same
> thing? This is what Android already does today:
> https://android-review.googlesource.com/198113

That's too late for setting up the kernel stack canary, among other
things. The kernel will also be generating some early secrets for slab
cache canaries, etc. That all needs to happen well before init is
started.

-Kees

-- 
Kees Cook
Pixel Security