Re: [RFC PATCH 2/3] dt-bindings: PCI: rockchip: Add support for pcie wake irq

[jeffy]

Hi Shawn,

On 08/16/2017 04:35 PM, Shawn Lin wrote:
> Hi Jeffy
>
> On 2017/8/16 15:52, Jeffy Chen wrote:
> > Add an optional interrupt for PCIE_WAKE pin.
> >
> > Signed-off-by: Jeffy Chen <jeffy.chen@xxxxxxxxxxxxxx>
> > ---
> >
> >   Documentation/devicetree/bindings/pci/rockchip-pcie.txt | 11
> > +++++++----
> >   1 file changed, 7 insertions(+), 4 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/pci/rockchip-pcie.txt
> > b/Documentation/devicetree/bindings/pci/rockchip-pcie.txt
> > index 1453a734c2f5..6ef9903567db 100644
> > --- a/Documentation/devicetree/bindings/pci/rockchip-pcie.txt
> > +++ b/Documentation/devicetree/bindings/pci/rockchip-pcie.txt
> > @@ -22,10 +22,13 @@ Required properties:
> >   - phys: From PHY bindings: Phandle for the Generic PHY for PCIe.
> >   - phy-names:  MUST be "pcie-phy".
> >   - interrupts: Three interrupt entries must be specified.
> > -- interrupt-names: Must include the following names
> > -    - "sys"
> > -    - "legacy"
> > -    - "client"
> > +- interrupt-names: Include the following names
> > +    Required:
> > +        - "sys"
> > +        - "legacy"
> > +        - "client"
> > +    Optional:
> > +        - "wake"
>
> It would be better to introduce interrupts-extended and show a example
> here. :)
ok, will add it in next version
> >   - resets: Must contain seven entries for each entry in reset-names.
> >          See ../reset/reset.txt for details.
> >   - reset-names: Must include the following names