Re: [PATCH V4 net-next 21/21] net-next/hinic: Add select_queue and netpoll

[Aviad Krawczyk]

Hi David,

Fixed in V6.
In V5 patch-set there was a problem in cover-letter msg-id.

Thanks,
Aviad

On 8/16/2017 9:47 PM, David Miller wrote:
> From: Aviad Krawczyk <aviad.krawczyk@xxxxxxxxxx>
> Date: Wed, 16 Aug 2017 20:03:06 +0800
> 
>> +static u16 hinic_select_queue(struct net_device *netdev, struct sk_buff *skb,
>> +			      void *accel_priv,
>> +			      select_queue_fallback_t fallback)
>> +{
>> +	u16 qid;
>> +
>> +	if (skb_rx_queue_recorded(skb))
>> +		qid = skb_get_rx_queue(skb);
>> +	else
>> +		qid = fallback(netdev, skb);
>> +
>> +	return qid;
>> +}
> 
> This is a NOP, do not implement this function unless you absolutely need to
> do something custom in your driver, and you do not.
> 
> .
>