Re: refactoring timers to avoid init_timer*()
From: Kees Cook
Date: Thu Aug 17 2017 - 11:08:45 EST
On Thu, Aug 17, 2017 at 7:40 AM, Christoph Hellwig <hch@xxxxxxxxxxxxx> wrote:
> Instea of bloating the timer even more we should kill off
> the data field eventually, which should give you the same
> protection.
>
> See my proposal and the related discussion here:
>
> http://www.mail-archive.com/linux-kernel@xxxxxxxxxxxxxxx/msg1397209.html
Ah! Yes, very cool. Most callbacks could be converted to the new timer
callback pretty easily. Some, though, pass non-pointer data in the
"data" argument. Those can likely be moved to somewhere else, though.
I think it should be possible to just perform all the conversions.
Regardless, getting rid of init_timer*() and eliminating the
open-coded callback assignments should help. I'll keep grinding on
that.
-Kees
--
Kees Cook
Pixel Security