Re: [PATCH v3 1/3] dt-bindings: Document the hi3660 thermal sensor bindings

[Rob Herring]

On Thu, Aug 10, 2017 at 04:32:13PM +0800, Tao Wang wrote:
> From: Tao Wang <kevin.wangtao@xxxxxxxxxx>
> 
> This adds documentation of device tree bindings for the
> thermal sensor controller of hi3660 SoC.
> 
> Signed-off-by: Tao Wang <kevin.wangtao@xxxxxxxxxx>
> ---
>  .../devicetree/bindings/thermal/hisi-tsensor.txt   | 23 ++++++++++++++++++++++
>  1 file changed, 23 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/thermal/hisi-tsensor.txt
> 
> diff --git a/Documentation/devicetree/bindings/thermal/hisi-tsensor.txt b/Documentation/devicetree/bindings/thermal/hisi-tsensor.txt
> new file mode 100644
> index 0000000..2ab0eb9
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/thermal/hisi-tsensor.txt
> @@ -0,0 +1,23 @@
> +* Temperature Sensor on hisilicon SoC
> +
> +** Required properties :
> +
> +- compatible: "hisilicon,thermal-tsensor".

Needs an SoC specific compatible.

> +- reg: physical base address of thermal sensor and length of memory mapped
> +  region.
> +- offset: reg offset of each sensor.

Should be implied by the compatible.

> +- coefficients:	An array of integers (one signed cell) containing
> +		coefficients to turn adc value to temperture.

Needs a vendor prefix.

> +- hisi,adc-range: adc value range, minimum value is followed by maximum value.
> +- #thermal-sensor-cells: Should be 1. See ./thermal.txt for a description.
> +
> +Example :
> +
> +tsensor: tsensor@FFF3000 {
> +	compatible = "hisilicon,tsensor";
> +	reg = <0x0 0xfff30000 0x0 0x1000>;
> +	offset = <0x1c 0x5c 0x9c>;
> +	coefficients = <165000 (-40000)>;
> +	hisi,adc-range = <0x74 0x39A>;
> +	#thermal-sensor-cells = <1>;
> +};
> -- 
> 2.8.1
> 
> --
> To unsubscribe from this list: send the line "unsubscribe devicetree" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html