Re: [PATCH v4 05/12] Documentation: net: phy: Add phy-is-internal binding
From: Rob Herring
Date: Thu Aug 17 2017 - 11:13:31 EST
On Thu, Aug 10, 2017 at 06:57:40PM +0800, David.Wu wrote:
> Hi Andrew, Florian
>
> å 2017/8/10 8:20, Andrew Lunn åé:
> > Hi Florian, David.
> >
> > I'm happy with the property name. But i think the text needs more
> > description. We deal with Ethernet switches with integrated PHYs. Yet
> > for us, this property is unneeded.
> >
> > Seeing this property means some bit of software needs to ensure the
> > internal PHY should be used, when given the choice between an internal
> > and external PHY. So i would say something like:
> >
> > If set, indicates that the PHY is integrated into the same
> > physical package as the Ethernet MAC. If needed, muxers should be
> > configured to ensure the (internal) PHY is used. The absence of this
> > property indicates the muxers should be configured so that the
> > external PHY is used.
>
> Are we supposed to replace the words "internal" with "integrated" here?
> So we have three kinds of PHY, they are intenal, external and integrated
> PHYs.
And you can have both a XAUI/serdes phy and the ethernet phy. It should
be clear this is for the latter.
Rob