Re: [PATCH 2/2] cpufreq: dt-platdev: Drop few entries from whitelist

From: Chen-Yu Tsai
Date: Thu Aug 17 2017 - 13:01:29 EST


On Wed, Aug 16, 2017 at 7:24 PM, Viresh Kumar <viresh.kumar@xxxxxxxxxx> wrote:
> On 16-08-17, 16:53, Chen-Yu Tsai wrote:
>> On Wed, Aug 16, 2017 at 1:37 PM, Viresh Kumar <viresh.kumar@xxxxxxxxxx> wrote:
>> > Drop few ARM (32 and 64 bit) platforms from the whitelist which always
>> > use "operating-points-v2" property from their DT. They should continue
>> > to work after this patch.
>> >
>> > Tested on Hikey platform (only the "hisilicon,hi6220" entry).
>> >
>> > Signed-off-by: Viresh Kumar <viresh.kumar@xxxxxxxxxx>
>> > ---
>> > drivers/cpufreq/cpufreq-dt-platdev.c | 11 -----------
>> > 1 file changed, 11 deletions(-)
>> >
>> > diff --git a/drivers/cpufreq/cpufreq-dt-platdev.c b/drivers/cpufreq/cpufreq-dt-platdev.c
>> > index 061b468512a2..45f2ec3b7f7a 100644
>> > --- a/drivers/cpufreq/cpufreq-dt-platdev.c
>> > +++ b/drivers/cpufreq/cpufreq-dt-platdev.c
>> > @@ -27,7 +27,6 @@ static const struct of_device_id whitelist[] __initconst = {
>> > { .compatible = "allwinner,sun6i-a31s", },
>> > { .compatible = "allwinner,sun7i-a20", },
>> > { .compatible = "allwinner,sun8i-a23", },
>> > - { .compatible = "allwinner,sun8i-a33", },
>> > { .compatible = "allwinner,sun8i-a83t", },
>> > { .compatible = "allwinner,sun8i-h3", },
>> >
>>
>> Acked-by: Chen-Yu Tsai <wens@xxxxxxxx>
>>
>> In fact, we can drop all the sun8i entries. Of them, only sun8i-a33 has
>> cpufreq implemented. All the other ones are missing thermal sensor support,
>> and no OPP tables have been added yet.
>
> Then, why did you guys add all those SoCs there ? :)

The idea was to add all the SoCs to the cpufreq driver first, and sort out
the thermal sensor and device tree parts later. Obviously this progressed
very slowly.

ChenYu