Re: [PATCH v3 1/9] ASoC: rt5514: Switch to snd_soc_register_codec

From: jeffy
Date: Thu Aug 17 2017 - 22:49:43 EST


Hi Mark,

On 08/18/2017 01:11 AM, Mark Brown wrote:
On Thu, Aug 17, 2017 at 12:44:09PM +0800, Jeffy Chen wrote:
Currently we are using devm_snd_soc_register_component, which would
use legacy dai name.

Switch to snd_soc_register_codec to use dai driver name.

This is the wrong direction to be going in, we are trying to move all
drivers to use component. Whatever you want to do make components use
it.


i was trying to make dai name use dai driver name:

/*
* Back in the old days when we still had component-less DAIs,
* instead of having a static name, component-less DAIs would
* inherit the name of the parent device so it is possible to
* register multiple instances of the DAI. We still need to keep
* the same naming style even though those DAIs are not
* component-less anymore.
*/
if (legacy_dai_naming &&
(dai_drv->id == 0 || dai_drv->name == NULL)) {
dai->name = fmt_single_name(dev, &dai->id);
} else {
dai->name = fmt_multiple_name(dev, dai_drv);


specify an non-zero id for dai driver works too, i'll do it in new patches :)