Re: [PATCH v2 15/16] dmaengine: bcm-sba-raid: Add debugfs support
From: Anup Patel
Date: Fri Aug 18 2017 - 01:25:56 EST
On Fri, Aug 18, 2017 at 10:56 AM, Vinod Koul <vinod.koul@xxxxxxxxx> wrote:
> On Fri, Aug 18, 2017 at 10:33:54AM +0530, Anup Patel wrote:
>> On Thu, Aug 17, 2017 at 1:31 PM, Vinod Koul <vinod.koul@xxxxxxxxx> wrote:
>> > On Tue, Aug 01, 2017 at 04:07:59PM +0530, Anup Patel wrote:
>> > why fail, debugfs should be an optional thingy, why would you want to fail here?
>>
>> Yes, we are handling the case when debugfs is not available
>> and skipping debugfs gracefully.
>>
>> If debugfs is available then failure of debugfs_create_dir()
>> should be reported.
>
> reported yes, bailing out on that err no..
OK, I will put dev_err() instead of bailing out.
Regards,
Anup