Re: [RFC v1 2/6] platform/x86: intel_pmc_ipc: Use devm_* calls in driver probe

[Andy Shevchenko]

On Tue, Aug 1, 2017 at 9:13 PM,
<sathyanarayanan.kuppuswamy@xxxxxxxxxxxxxxx> wrote:
> From: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@xxxxxxxxxxxxxxx>
>
> This patch cleans up unnecessary free/alloc calls in this driver
> by using devm_* calls.

>  static int ipc_plat_remove(struct platform_device *pdev)
>  {
> -       struct resource *res;
> -
>         sysfs_remove_group(&pdev->dev.kobj, &intel_ipc_group);

> -       free_irq(ipcdev.irq, &ipcdev);

Can we get an IRQ at any time here?

>         platform_device_unregister(ipcdev.tco_dev);
>         platform_device_unregister(ipcdev.punit_dev);
>         platform_device_unregister(ipcdev.telemetry_dev);

>         ipcdev.dev = NULL;
>         return 0;
>  }


-- 
With Best Regards,
Andy Shevchenko