Re: [PATCH net-next 2/3] vsock: fix vsock_dequeue/enqueue_accept race

From: Stefan Hajnoczi
Date: Fri Aug 18 2017 - 11:50:31 EST


On Tue, Aug 15, 2017 at 10:15:39PM +0000, Dexuan Cui wrote:
> With the current code, when vsock_dequeue_accept() is removing a sock
> from the list, nothing prevents vsock_enqueue_accept() from adding a new
> sock into the list concurrently. We should add a lock to protect the list.

The listener sock is locked, preventing concurrent modification. I have
checked both the virtio and vmci transports. Can you post an example
where the listener sock isn't locked?

Stefan

Attachment: signature.asc
Description: PGP signature