Re: [PATCH v2] Kbuild: use -fshort-wchar globally

From: Arnd Bergmann
Date: Sun Aug 20 2017 - 15:23:22 EST


On Sun, Aug 20, 2017 at 2:31 PM, Masahiro Yamada
<yamada.masahiro@xxxxxxxxxxxxx> wrote:
> Hi Arnd,
>
> This patch was picked up for linux-next
> (I assume it was queued up for 4.14-rc1)
> but I see this warning in Linus' tree.
>
> If we are not comfortable with this warning in the 4.13 release,
> shall I include this patch in the kbuild/fixes pull request?
> (planned this week)
>
> Please let me know your thought.

Yes, I think it would be good to have in 4.13, since it's a regression
against older kernels.

> 2017-07-26 22:36 GMT+09:00 Arnd Bergmann <arnd@xxxxxxxx>:
>> A previous patch added the --no-wchar-size-warning to the Makefile to
>> avoid this harmless warning:
>
> "A previous patch" sounds ambiguous.
>
> The previous patch was applied one year ago.
>
>
> If it is OK, I can reword like
>
> Commit 971a69db7dc0 ("Xen: don't warn about 2-byte wchar_t in efi") added ...

Good idea, thanks!

Arnd