Re: [RFC 2/3] rtc: Add Realtek RTD1295

[Andreas FÃrber]

Am 20.08.2017 um 17:40 schrieb Andrew Lunn:
>> +static void rtd119x_rtc_set_enabled(struct device *dev, bool enable)
>> +{
>> +	struct rtd119x_rtc *data = dev_get_drvdata(dev);
>> +	u32 val;
>> +
>> +	val = readl_relaxed(data->base + RTD_RTCEN);
>> +	dev_info(dev, "%s: rtcen = 0x%08x\n", __func__, val);
> 
> dev_dbg()?
> 
>> +static int rtd119x_rtc_open(struct device *dev)
>> +{
>> +	struct rtd119x_rtc *data = dev_get_drvdata(dev);
>> +	u32 val;
>> +	int ret;
>> +
>> +	ret = clk_prepare_enable(data->clk);
>> +	if (ret)
>> +		return ret;
>> +
>> +	val = readl_relaxed(data->base + RTD_RTCACR);
>> +	dev_info(dev, "rtcacr = 0x%08x\n", val);
> 
> dev_dbg()?

Yeah, either that or dropping them altogether.

Thanks,
Andreas

-- 
SUSE Linux GmbH, Maxfeldstr. 5, 90409 NÃrnberg, Germany
GF: Felix ImendÃrffer, Jane Smithard, Graham Norton
HRB 21284 (AG NÃrnberg)