Re: [PATCH] staging: vboxvideo: constify drm_fb_helper_funcs

[Hans de Goede]

Hi,

On 21-08-17 12:06, Arvind Yadav wrote:
> drm_fb_helper_funcs are not supposed to change at runtime.
> All functions working with drm_fb_helper_funcs provided by
> <drm/drm_fb_helper.h> work with const drm_fb_helper_funcs.
> So mark the non-const structs as const.
>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@xxxxxxxxx>

Thanks, patch looks good to me:

Reviewed-by: Hans de Goede <hdegoede@xxxxxxxxxx>

Regards,

Hans


> ---
>   drivers/staging/vboxvideo/vbox_fb.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/vboxvideo/vbox_fb.c b/drivers/staging/vboxvideo/vbox_fb.c
> index 35f6d9f..70d99b7 100644
> --- a/drivers/staging/vboxvideo/vbox_fb.c
> +++ b/drivers/staging/vboxvideo/vbox_fb.c
> @@ -330,7 +330,7 @@ static void vbox_fb_gamma_get(struct drm_crtc *crtc, u16 *red, u16 *green,
>   	*blue = regno;
>   }
>   
> -static struct drm_fb_helper_funcs vbox_fb_helper_funcs = {
> +static const struct drm_fb_helper_funcs vbox_fb_helper_funcs = {
>   	.gamma_set = vbox_fb_gamma_set,
>   	.gamma_get = vbox_fb_gamma_get,
>   	.fb_probe = vboxfb_create,