Re: [PATCH 03/14] mmc: meson-gx: clean up some constants

[Jerome Brunet]

On Mon, 2017-08-07 at 14:06 -0700, Kevin Hilman wrote:
> Jerome Brunet <jbrunet@xxxxxxxxxxxx> writes:
> 
> > Remove useless clock rate defines. These should not be defined but
> 
> To be more precise, they're also unused, so maybe s/useless/unused/ ?
> 
> > equested from the clock framework.
> 
> s/equested/requested/
> 

Thx Kevin !

> > Also correct typo on the DELAY register
> > 
> > Signed-off-by: Jerome Brunet <jbrunet@xxxxxxxxxxxx>
> 
> Otherwise,
> 
> Reviewed-by: Kevin Hilman <khilman@xxxxxxxxxxxx>
> 
> > ---
> > Âdrivers/mmc/host/meson-gx-mmc.c | 4 +---
> > Â1 file changed, 1 insertion(+), 3 deletions(-)
> > 
> > diff --git a/drivers/mmc/host/meson-gx-mmc.c b/drivers/mmc/host/meson-gx-
> > mmc.c
> > index d480a8052a06..8a74a048db88 100644
> > --- a/drivers/mmc/host/meson-gx-mmc.c
> > +++ b/drivers/mmc/host/meson-gx-mmc.c
> > @@ -45,9 +45,7 @@
> > Â#defineÂÂÂCLK_DIV_MAX 63
> > Â#defineÂÂÂCLK_SRC_MASK GENMASK(7, 6)
> > Â#defineÂÂÂCLK_SRC_XTAL 0ÂÂÂ/* external crystal */
> > -#defineÂÂÂCLK_SRC_XTAL_RATE 24000000
> > Â#defineÂÂÂCLK_SRC_PLL 1ÂÂÂÂ/* FCLK_DIV2 */
> > -#defineÂÂÂCLK_SRC_PLL_RATE 1000000000
> > Â#defineÂÂÂCLK_CORE_PHASE_MASK GENMASK(9, 8)
> > Â#defineÂÂÂCLK_TX_PHASE_MASK GENMASK(11, 10)
> > Â#defineÂÂÂCLK_RX_PHASE_MASK GENMASK(13, 12)
> > @@ -57,7 +55,7 @@
> > Â#defineÂÂÂCLK_PHASE_270 3
> > Â#defineÂÂÂCLK_ALWAYS_ON BIT(24)
> > Â
> > -#define SD_EMMC_DElAY 0x4
> > +#define SD_EMMC_DELAY 0x4
> > Â#define SD_EMMC_ADJUST 0x8
> > Â#define SD_EMMC_CALOUT 0x10
> > Â#define SD_EMMC_START 0x40