Re: [PATCH v4 1/3] ASoC: codecs: msm8916-wcd-analog: get micbias voltage from dt

[Mark Brown]

On Thu, Aug 17, 2017 at 10:02:09AM +0200, srinivas.kandagatla@xxxxxxxxxx wrote:

> +		/*
> +		 * Special headset needs MICBIAS as 2.7V so wait for
> +		 * 50 msec for the MICBIAS to reach 2.7 volts.
> +		 */
> +		if (wcd->micbias_mv >= 2700)
> +			msleep(50);

This doesn't sound like how ramping usually works?  Normally it'd be at
least somewhat proportional to voltage, a sudden cutoff like this seems
strange.  I'll apply but this looks like it needs fixing, please send an
incremental patch.

Attachment: signature.asc
Description: PGP signature