Re: ALSA: pcsp: Use common error handling code in snd_card_pcsp_probe()

From: SF Markus Elfring
Date: Tue Aug 22 2017 - 08:53:16 EST

Next message: Boris Brezillon: "Re: [PATCH v6] mtd: sharpslpart: Add sharpslpart partition parser"
Previous message: Linus Walleij: "Re: [PATCH v3] pinctrl: aspeed: Fix ast2500 strap register write logic"
In reply to: Takashi Iwai: "Re: [PATCH] ALSA: pcsp: Use common error handling code in snd_card_pcsp_probe()"
Next in thread: Takashi Iwai: "Re: [alsa-devel] ALSA: pcsp: Use common error handling code in snd_card_pcsp_probe()"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

> Also, please don't omit the negative value check.

Is it appropriate to treat non-zero values as error codes there generally?

Regards,
Markus

Next message: Boris Brezillon: "Re: [PATCH v6] mtd: sharpslpart: Add sharpslpart partition parser"
Previous message: Linus Walleij: "Re: [PATCH v3] pinctrl: aspeed: Fix ast2500 strap register write logic"
In reply to: Takashi Iwai: "Re: [PATCH] ALSA: pcsp: Use common error handling code in snd_card_pcsp_probe()"
Next in thread: Takashi Iwai: "Re: [alsa-devel] ALSA: pcsp: Use common error handling code in snd_card_pcsp_probe()"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]