Re: [PATCH] tools/perf: really install manpages by make install-man

From: Arnaldo Carvalho de Melo
Date: Tue Aug 22 2017 - 11:46:37 EST


Em Sun, Aug 20, 2017 at 02:39:13PM +0300, Konstantin Khlebnikov escreveu:
> Target install-man builds them but forget to install.

Thanks, applied, I guess nobody noticed that because the man pages _are_
installed when using plain 'make -C tools/perf install', as it calls
'try-install-man' and it, in turn, uses do-install-man.

- Arnaldo

> Signed-off-by: Konstantin Khlebnikov <khlebnikov@xxxxxxxxxxxxxx>
> ---
> tools/perf/Documentation/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/perf/Documentation/Makefile b/tools/perf/Documentation/Makefile
> index 098cfb9ca8f0..db11478e30b4 100644
> --- a/tools/perf/Documentation/Makefile
> +++ b/tools/perf/Documentation/Makefile
> @@ -192,7 +192,7 @@ do-install-man: man
> # $(INSTALL) -m 644 $(DOC_MAN5) $(DESTDIR)$(man5dir); \
> # $(INSTALL) -m 644 $(DOC_MAN7) $(DESTDIR)$(man7dir)
>
> -install-man: check-man-tools man
> +install-man: check-man-tools man do-install-man
>
> ifdef missing_tools
> DO_INSTALL_MAN = $(warning Please install $(missing_tools) to have the man pages installed)