Re: [PATCH][next] efi/reboot: make function pointer orig_pm_power_off static

[Ard Biesheuvel]

On 22 August 2017 at 16:50, Colin King <colin.king@xxxxxxxxxxxxx> wrote:
> From: Colin Ian King <colin.king@xxxxxxxxxxxxx>
>
> The function pointer orig_pm_power_off is local to the source and does
> not need to be in global scope, so make it static.
>
> Cleans up sparse warning:
> symbol 'orig_pm_power_off' was not declared. Should it be static?
>
> Signed-off-by: Colin Ian King <colin.king@xxxxxxxxxxxxx>

Queued, thanks.

> ---
>  drivers/firmware/efi/reboot.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/firmware/efi/reboot.c b/drivers/firmware/efi/reboot.c
> index 7117e2d0c7f9..22874544d301 100644
> --- a/drivers/firmware/efi/reboot.c
> +++ b/drivers/firmware/efi/reboot.c
> @@ -5,7 +5,7 @@
>  #include <linux/efi.h>
>  #include <linux/reboot.h>
>
> -void (*orig_pm_power_off)(void);
> +static void (*orig_pm_power_off)(void);
>
>  int efi_reboot_quirk_mode = -1;
>
> --
> 2.14.1
>