Re: [PATCH v7 5/7] io-64-nonatomic: add io{read|write}64[be]{_lo_hi|_hi_lo} macros
From: Logan Gunthorpe
Date: Tue Aug 22 2017 - 13:55:57 EST
On 22/08/17 11:40 AM, Andy Shevchenko wrote:
ldd -> LDD
Ok.
Recomendation is kinda arguable. I doubt modern architectures make
difference between IO operations and MMIO.
Does, for example, PCI requires some special signal (message / wire)
handling when pio_*() accessors used vs. mmio_*() ones?
Sort of. There is a difference between the two in x86. But really if
it's not a valid recommendation someone should just go through and
deprecate one of them or document better when one should be used over
the other. In any case it's still really ugly to mix the two types in
the same driver.
cc -> Cc ?
Fixed.
Logan