Re: [PATCH v2 1/6] fsl/fman: enable FMan Keygen

From: David Miller
Date: Tue Aug 22 2017 - 17:35:19 EST


From: Madalin Bucur <madalin.bucur@xxxxxxx>
Date: Tue, 22 Aug 2017 20:31:01 +0300

> /**
> + * fman_get_keygen
> + *
> + * @fman: A Pointer to FMan device
> + *
> + * Get the handle to KeyGen module part of FM driver
> + *
> + * Return: Handle to KeyGen
> + */
> +struct fman_keygen *fman_get_keygen(struct fman *fman)
> +{
> + return fman->keygen;
> +}
> +EXPORT_SYMBOL(fman_get_keygen);

Please don't do this.

Just directly derefence the pointer in the source code to
get the keygen.

Thank you.