Re: [PATCH][next] MIPS,bpf: fix missing break in switch statement

[Daniel Borkmann]

On 08/23/2017 12:29 AM, David Daney wrote:
> On 08/22/2017 03:03 PM, Colin King wrote:
> > From: Colin Ian King <colin.king@xxxxxxxxxxxxx>
> >
> > There is a missing break causing a fall-through and setting
> > ctx.use_bbit_insns to the wrong value. Fix this by adding the
> > missing break.
> >
> > Detected with cppcheck:
> > "Variable 'ctx.use_bbit_insns' is reassigned a value before the old
> > one has been used. 'break;' missing?"
> >
> > Fixes: 8d8d18c3283f ("MIPS,bpf: Fix using smp_processor_id() in preemptible splat.")
> > Signed-off-by: Colin Ian King <colin.king@xxxxxxxxxxxxx>
>
> Crap!  That slipped through.  Thanks for fixing it.
>
> Tested and ...
>
> Acked-by: David Daney <david.daney@xxxxxxxxxx>

Colin, can you send this with David's ACK to netdev in Cc
so it lands in patchwork? It's for net-next tree. Thanks!