Re: [PATCH v3] pinctrl: aspeed: Fix ast2500 strap register write logic

From: Andrew Jeffery
Date: Tue Aug 22 2017 - 19:54:23 EST


Hi Linus,

On Tue, 2017-08-22 at 14:52 +0200, Linus Walleij wrote:
> > On Tue, Aug 15, 2017 at 6:21 PM, Yong Li <sdliyong@xxxxxxxxx> wrote:
>Â
> > On AST2500, the hardware strap register(SCU70) only accepts write â1â,
> > to clear it to â0â, must set bits(writeÂÂâ1â) to SCU7C
>
> > Signed-off-by: Yong Li <sdliyong@xxxxxxxxx>
>Â
> Patch applied with Andrew's review/test tags.

I realised after I sent the tags on v3 that I'd made a mistake: There's a
slightly awkward to test bug in the v3 implementation. I followed up on v3 with
this:

https://lkml.org/lkml/2017/8/16/905

And Yong sent out a corresponding v4:

https://patchwork.ozlabs.org/patch/802946/

I see you've pushed Yong's v3 in pinctrl/devel - can we revert/remove that and
apply v4?

Sorry for the confusion.

Andrew

>Â
> Yours,
> Linus Walleij

Attachment: signature.asc
Description: This is a digitally signed message part