Re: [PATCH v4] iio: accel: mma8452: improvements to handle multiple events

[Harinath Nampally]

> If rising: use transient OR ff_mt device-dependent like before. But 
> now save it in a simple flag,
> whether transient registers are available.
Ok, is it good idea to add the flag to struct mma_chip_info like below?

  * @mma_scales:                        scale factors for converting 
register values
  *                             to m/s^2; 3 modes: 2g, 4g, 8g; 2 integers
  *                             per mode: m/s^2 and micro m/s^2
+ * @transient_supported:       flag indicating whether chip support 
transient
+ *                             event, as not all chips support 
transient event
  */
 struct mma_chip_info {
        u8 chip_id;
        const struct iio_chan_spec *channels;
        int num_channels;
        const int mma_scales[3][2];
+       bool transient_supported;
 };

> If falling: switch to ff_mt in any case. (fixing freefall for the 
> transient-devices) 
ok sure.

Thanks,

Hari

On 08/21/2017 04:47 AM, Martin Kepplinger wrote:
> If rising: use transient OR ff_mt device-dependent like before. But 
> now save it in a simple flag,
> whether transient registers are available.
>
> If falling: switch to ff_mt in any case. (fixing freefall for the 
> transient-devices)