Re: [PATCH v2] irqchip: uniphier-aidet: add UniPhier AIDET irqchip driver

From: Rob Herring
Date: Tue Aug 22 2017 - 20:40:20 EST


On Mon, Aug 21, 2017 at 07:01:03PM +0900, Masahiro Yamada wrote:
> UniPhier SoCs contain AIDET (ARM Interrupt Detector). This is intended
> to provide additional features that are not covered by GIC. The main
> purpose is to provide logic inverter to support low level and falling
> edge trigger type for interrupt lines from on-board devices.
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@xxxxxxxxxxxxx>
> ---
>
> Changes in v2:
> - Use readl/write_relaxed instead of readl/writel
> - Move val = 0 for code symmetry
> - .alloc() hook only supports nr_irqs==1 case
> - Move struct irq_chip to static data because this driver expects
> only one device instance in the system
> - Match the interrupt number to SPI of GIC to make DT binding clearer
> (register offset starts from 0x4)
>
> .../socionext,uniphier-aidet.txt | 32 +++

Acked-by: Rob Herring <robh@xxxxxxxxxx>

> MAINTAINERS | 1 +
> drivers/irqchip/Kconfig | 8 +
> drivers/irqchip/Makefile | 1 +
> drivers/irqchip/irq-uniphier-aidet.c | 246 +++++++++++++++++++++
> 5 files changed, 288 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/interrupt-controller/socionext,uniphier-aidet.txt
> create mode 100644 drivers/irqchip/irq-uniphier-aidet.c