Re: [PATCH 3/3] ARM: dts: sun8i: Add board dts file for Banana Pi M2 Berry

From: Icenowy Zheng
Date: Wed Aug 23 2017 - 01:47:05 EST



ä 2017å8æ23æ GMT+08:00 äå4:12:15, Maxime Ripard <maxime.ripard@xxxxxxxxxxxxxxxxxx> åå:
>On Tue, Aug 22, 2017 at 02:17:42PM +0800, Icenowy Zheng wrote:
>> +&reg_vcc5v0 {
>> + gpio = <&pio 7 23 GPIO_ACTIVE_HIGH>; /* PH23 */
>> + enable-active-high;
>> +};
>
>Same thing here, you're not using that regulator anywhere. You don't
>even use any of the regulators in sunxi-common-regulators.

Maybe I should drop the regulator now, and re-introduce it when adding USB/SATA?

>
>Maxime