Re: [PATCH v9 1/2] serio: PS/2 gpio bit banging driver for serio bus

From: Linus Walleij
Date: Wed Aug 23 2017 - 04:29:31 EST

Next message: SF Markus Elfring: "[PATCH 5/6] ALSA: timer: Adjust a condition check in snd_timer_resolution()"
Previous message: Anshuman Khandual: "[PATCH] mm/page_fault: Remove reduntant check for write access"
In reply to: Danilo Krummrich: "[PATCH v9 1/2] serio: PS/2 gpio bit banging driver for serio bus"
Next in thread: Danilo Krummrich: "[PATCH v9 2/2] dt-bindings: new binding for ps/2 gpio devices"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

On Mon, Aug 21, 2017 at 9:31 PM, Danilo Krummrich
<danilokrummrich@xxxxxxxxxxxxx> wrote:

> +static int __ps2_gpio_write(struct serio *serio, unsigned char val)
> +static int ps2_gpio_write(struct serio *serio, unsigned char val)

I never like the random use of __prefixes as they have unclear
semantics.

I would name it something concise.

Anyways, that is up to the subsystem maintainer.
>From a GPIO point of view:
Reviewed-by: Linus Walleij <linus.walleij@xxxxxxxxxx>

Yours,
Linus Walleij

Next message: SF Markus Elfring: "[PATCH 5/6] ALSA: timer: Adjust a condition check in snd_timer_resolution()"
Previous message: Anshuman Khandual: "[PATCH] mm/page_fault: Remove reduntant check for write access"
In reply to: Danilo Krummrich: "[PATCH v9 1/2] serio: PS/2 gpio bit banging driver for serio bus"
Next in thread: Danilo Krummrich: "[PATCH v9 2/2] dt-bindings: new binding for ps/2 gpio devices"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]