Re: [PATCH v3] pinctrl: aspeed: Fix ast2500 strap register write logic

[Andrew Jeffery]

On Wed, 2017-08-23 at 10:23 +0200, Linus Walleij wrote:
> > On Wed, Aug 23, 2017 at 1:54 AM, Andrew Jeffery <andrew@xxxxxxxx> wrote:
> > On Tue, 2017-08-22 at 14:52 +0200, Linus Walleij wrote:
> > > > > > > > On Tue, Aug 15, 2017 at 6:21 PM, Yong Li <sdliyong@xxxxxxxxx> wrote:
> > > > On AST2500, the hardware strap register(SCU70) only accepts write â1â,
> > > > to clear it to â0â, must set bits(writeÂÂâ1â) to SCU7C
> > > >Â
> > > > Signed-off-by: Yong Li <sdliyong@xxxxxxxxx>
> > >Â
> > > Patch applied with Andrew's review/test tags.
> >Â
> > I realised after I sent the tags on v3 that I'd made a mistake: There's a
> > slightly awkward to test bug in the v3 implementation. I followed up on v3 with
> > this:
> >Â
> > ÂÂÂÂÂÂÂÂhttps://lkml.org/lkml/2017/8/16/905
> >Â
> > And Yong sent out a corresponding v4:
> >Â
> > ÂÂÂÂÂÂÂÂhttps://patchwork.ozlabs.org/patch/802946/
>Â
> Ah. I got confused and picked the wrong version.

Entirely my fault. Apologies again for the confusion. I owe you a few drinks if
we ever meet :)

>Â
> > I see you've pushed Yong's v3 in pinctrl/devel - can we revert/remove that and
> > apply v4?
>Â
> No I would have to revert the patch.
>Â
> Can't we simply make a small fixup patch?

I couldn't recall what the rebase policy was for pinctrl/devel.

I have sent the fixup patch:

	http://patchwork.ozlabs.org/patch/804981/

Cheers,

Andrew

>Â
> Yours,
> Linus Walleij

Attachment: signature.asc
Description: This is a digitally signed message part