Re: [PATCH] ALSA: ctxfi: make hw structures const

[Takashi Iwai]

On Wed, 23 Aug 2017 14:28:42 +0200,
Bhumika Goyal wrote:
> 
> Make these const as they are only used in a copy operation.
> Done using Coccinelle:
> 
> @match disable optional_qualifier@
> identifier s;
> @@
> static struct hw s = {...};
> 
> @ref@
> position p;
> identifier match.s;
> @@
> s@p
> 
> @good1@
> position ref.p;
> identifier match.s,f,c;
> expression e;
> @@
> (
> e = s@p
> |
> e = s@xxx
> |
> c(...,s@xxx,...)
> |
> c(...,s@p,...)
> )
> 
> @bad depends on  !good1@
> position ref.p;
> identifier match.s;
> @@
> s@p
> 
> @depends on forall !bad disable optional_qualifier@
> identifier match.s;
> @@
> static
> + const
> struct hw s;
> 
> Signed-off-by: Bhumika Goyal <bhumirks@xxxxxxxxx>

Applied, thanks.


Takashi