Re: [PATCH v3 2/5] intel_pstate: convert to use acpi_match_platform_list()

From: Kani, Toshimitsu
Date: Wed Aug 23 2017 - 11:56:16 EST


On Wed, 2017-08-23 at 17:46 +0200, Borislav Petkov wrote:
> On Fri, Aug 18, 2017 at 01:46:41PM -0600, Toshi Kani wrote:
> > Convert to use acpi_match_platform_list() for the platform check.
> > There is no change in functionality.
> >
:
>
> Btw, why is that ACPI_SIG_FADT's description not "FADT" ?
>
> #define ACPI_SIG_FADTÂÂÂÂÂÂÂÂÂÂÂ"FACP"ÂÂ/* Fixed ACPI Description
> Table */
>
> More ACPI fun? I don't think I can take any more fun.

Yes, more ACPI fun. :-) According to the spec:

âFACPâ. Signature for the Fixed ACPI Description Table. (This signature
predates ACPI 1.0, explaining the mismatch with this table's name.)

> Oh well,
>
> Reviewed-by: Borislav Petkov <bp@xxxxxxx>

Thanks!
-Toshi