Re: [PATCH] scsi: lpfc: remove useless code in lpfc_sli4_bsg_link_diag_test

[James Smart]

On 8/22/2017 1:53 PM, Gustavo A. R. Silva wrote:
> Remove variable assignments. The value stored in local variable _rc_ is
> overwritten at line 2448:rc = lpfc_sli4_bsg_set_link_diag_state(phba, 0);
> before it can be used.
>
> Addresses-Coverity-ID: 1226935
> Signed-off-by: Gustavo A. R. Silva <gustavo@xxxxxxxxxxxxxx>
> ---
> This issue was detected by Coverity and it was tested by compilation only.
> Notice that this code has been there since 2011.
>
>   drivers/scsi/lpfc/lpfc_bsg.c | 9 +++------
>   1 file changed, 3 insertions(+), 6 deletions(-)

looks good. Thanks

Signed-off-by: James Smart <james.smart@xxxxxxxxxxxx>

-- james