Re: [PATCH] ACPI, APEI, EINJ: Subtract any matching Register Region from Trigger resources

[Luck, Tony]

On Wed, Aug 23, 2017 at 04:37:43PM +0000, Ghannam, Yazen wrote:
> > -----Original Message-----
> > From: Luck, Tony [mailto:tony.luck@xxxxxxxxx]
> > Maybe you should add the other instruction types that make sense here
> > (ACPI_EINJ_READ_REGISTER, ACPI_EINJ_READ_REGISTER_VALUE and
> > ACPI_EINJ_WRITE_REGISTER) as a sanity check against the BIOS giving you an
> > action in the trigger table that doesn't involve a memory access?
> > 
> 
> Yes, in that case we can do:
> entry->instruction <= ACPI_EINJ_WRITE_REGISTER_VALUE
> 
> That would cover all the memory access instructions and protect against invalid
> instructions.
> 
> How does that sound?

Perfect.

Acked-by: Tony Luck <tony.luck@xxxxxxxxx>

-Tony