Re: [PATCH] x86/nmi/64: avoid passing user space rsp of pt_regs to nmi handler

From: oliver yang
Date: Wed Aug 23 2017 - 13:34:45 EST


2017-08-24 0:51 GMT+08:00 Andy Lutomirski <luto@xxxxxxxxxxxxxx>:
> To avoid further wasting time solving this wrong: NAK. pt_regs is the actual interrupted state, not some oddly sanitized version thereof. NMI isn't even the only way you can have a weird pt_regs like this.
>
> It seems that some older kernels contain bugs where they incorrectly assume that regs->rsp is a valid pointer. Why don't you write a patch for *that * and send it to lkml, us, and stable@xxxxxxxxxxxxxxxx

Got it. Thanks for clear answer.

I agree that pt_regs users should handle it, if the pt_regs reflects
the actual interrupted status.


--
------------------
Oliver Yang