Re: [PATCH] usb:xhci:Fix regression when ATI chipsets detected

[Greg KH]

On Wed, Aug 23, 2017 at 04:26:00PM +0530, Sandeep Singh wrote:
> From: Sandeep Singh <sandeep.singh@xxxxxxx>
> 
> The following commit cause a regression on ATI chipsets.
> 'commit e788787ef4f9 ("usb:xhci:Add quirk for Certain
> failing HP keyboard on reset after resume")'
> 
> This causes pinfo->smbus_dev to be wrongly set to NULL on
> systems with the ATI chipset that this function checks for first.
> 
> Added conditional check for AMD chipsets to avoid the overwriting
> pinfo->smbus_dev.
> 
> Reported-by: Ben Hutchings <ben@xxxxxxxxxxxxxxx>
> Signed-off-by: Sandeep Singh <Sandeep.Singh@xxxxxxx>
> Signed-off-by: Shyam Sundar S K <Shyam-sundar.S-k@xxxxxxx>
> cc: Nehal Shah <Nehal-bakulchandra.Shah@xxxxxxx>

A "Fixes:" tag here would be good, as would a "cc:
stable@xxxxxxxxxxxxxxx" right?

And you have tested this out well, right?

thanks,

greg k-h