Re: [PATCH] printk-formats.txt: Add examples for %pS and %pF
From: Steven Rostedt
Date: Wed Aug 23 2017 - 22:11:17 EST
On Thu, 24 Aug 2017 09:41:03 +0900
Sergey Senozhatsky <sergey.senozhatsky.work@xxxxxxxxx> wrote:
> On (08/23/17 16:48), Petr Mladek wrote:
> [..]
> > Sometimes people seems unclear when to use the %pS or %pF printk format.
> > For example, see commit 51d96dc2e2dc ("random: fix warning message on ia64
> > and parisc") which fixed such a wrong format string.
> >
> > The documentation should be more clear about the difference.
> > Also examples might help to avoid some typical mistakes.
> >
> > Signed-off-by: Helge Deller <deller@xxxxxx>
> > [pmladek@xxxxxxxx: Restructure the entire section]
> > Signed-off-by: Petr Mladek <pmladek@xxxxxxxx>
>
> looks great.
>
> FWIW,
> Reviewed-by: Sergey Senozhatsky <sergey.senozhatsky@xxxxxxxxx>
Also,
Acked-by: Steven Rostedt (VMware) <rostedt@xxxxxxxxxxx>
-- Steve