Re: [PATCH net-next v7 01/10] selftest: Enhance kselftest_harness.h with a step mechanism
From: Alexei Starovoitov
Date: Wed Aug 23 2017 - 22:32:02 EST
On Mon, Aug 21, 2017 at 02:09:24AM +0200, Mickaël Salaün wrote:
> This step mechanism may be useful to return an information about the
> error without being able to write to TH_LOG_STREAM.
>
> Set _metadata->no_print to true to print this counter.
>
> Signed-off-by: Mickaël Salaün <mic@xxxxxxxxxxx>
> Cc: Andy Lutomirski <luto@xxxxxxxxxxxxxx>
> Cc: Arnaldo Carvalho de Melo <acme@xxxxxxxxxx>
> Cc: Kees Cook <keescook@xxxxxxxxxxxx>
> Cc: Shuah Khan <shuah@xxxxxxxxxx>
> Cc: Will Drewry <wad@xxxxxxxxxxxx>
> Link: https://lkml.kernel.org/r/CAGXu5j+D-FP8Kt9unNOqKrQJP4DYTpmgkJxWykZyrYiVPz3Y3Q@xxxxxxxxxxxxxx
> ---
>
> This patch is intended to the kselftest tree:
> https://lkml.kernel.org/r/20170806232337.4191-1-mic@xxxxxxxxxxx
>
> Changes since v6:
> * add the step counter in assert/expect macros and use _metadata to
> enable the counter (suggested by Kees Cook)
> ---
> tools/testing/selftests/kselftest_harness.h | 31 ++++++++++++++++++++++-----
> tools/testing/selftests/seccomp/seccomp_bpf.c | 2 +-
> 2 files changed, 27 insertions(+), 6 deletions(-)
is there a dependency on this in patches 2+ ?
if not, I would send this patch to selftests right away.