Re: [PATCH] ASoC: Add a sanity check before using dai driver name

[jeffy]

Hi Mark,

On 08/23/2017 07:06 PM, Mark Brown wrote:
> On Wed, Aug 23, 2017 at 07:42:55AM +0800, jeffy wrote:
>
> > >i think the original check is allowing NULL dlc dai_name to be a match...
> > >so we basically did:
> > >reject when dlc dai_name is valid, but not match the dai name
> So it is, but this still looks like the wrong thing - it'll match on an
> empty DAI name over an explicit match on the driver name which seems
> like it's the wrong way round.
sorry, i don't know much about asoc, so i just trying to keep the 
original conditions and add the new one on it :)

the original one is:
if (dlc->dai_name && strcmp(dai->name, dlc->dai_name))
   continue;

and i was trying to do something like:
if (dlc->dai_name && strcmp(dai->name, dlc->dai_name)
    && (!dai->driver->name || strcmp(dai->driver->name, dlc->dai_name)))
   continue;

which is add an accept case for: dai driver name is valid and matches 
the dai name we are looking for...