Re: [PATCH] ASoC: rt5677: Reintroduce I2C device IDs

From: Andy Shevchenko
Date: Thu Aug 24 2017 - 03:42:07 EST


On Wed, 2017-08-23 at 20:05 -0400, Tom Rini wrote:
> On Wed, Aug 23, 2017 at 01:39:12PM -0400, Tom Rini wrote:
> > On Wed, Aug 23, 2017 at 05:29:33PM +0300, Andy Shevchenko wrote:
> >
> > > On Tue, 2017-08-22 at 21:51 -0400, Tom Rini wrote:
> > > > Not all devices with ACPI and this combination of sound devices
> > > > will
> > > > have the required information provided via ACPI.ÂÂReintroduce
> > > > the I2C
> > > > device ID to restore sound functionality on on the Chromebook
> > > > 'Samus'
> > > > model.
> > > > This is a regression from v4.12 on my laptop (a Chromebook
> > > > 'Samus'
> > > > that's not running ChromeOS).ÂÂMy fault for getting out of the
> > > > habit
> > > > of
> > > > trying -rc1 when it comes out and not spotting this sooner.ÂÂI'm
> > > > not
> > > > 100% sure if this fix is correct for all cases as I'm only able
> > > > to
> > > > test
> > > > my hardware here, and this does fix my laptop.
> > >
> > > Are you sure the commit ddc9e69b9dc2 ("ASoC: rt5677: Hide platform
> > > data
> > > in the module sources") does not fix your issue?
> >
> > As that's not in master yet I can't tell.ÂÂCan you give me a pointer
> > to
> > somewhere?

It's in ASoC next at least.

> > ÂÂThanks!
>
> OK, my bad, it has a different hash upstream, but no, that change
> doesn't fix things as I see the problem on top of Linus'
> tree.ÂÂThanks!

Interesting...

The only bug so far I saw is the following one

https://bugzilla.kernel.org/show_bug.cgi?id=196397

...and above commit fixes it.

Can you place somewhere the bundle of the following:

1. Output file (tables.dat) of
% acpidump -o tables.dat
2. Output of
% cat /proc/interrupts
3. Output of
% lspci -vv -xx
4. Output of
% grep -H 15 /sys/bus/acpi/devices/*/status

?

--
Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
Intel Finland Oy